Skip to content

Fix typo in CODEOWNERS file #8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2022
Merged

Fix typo in CODEOWNERS file #8000

merged 1 commit into from
Feb 3, 2022

Conversation

jankeromnes
Copy link
Contributor

@jankeromnes jankeromnes commented Feb 3, 2022 •
edited
Loading

😇

Release Notes

NONE

@jankeromnes jankeromnes requested review from mads-hartmann and a team February 3, 2022 09:42
@github-actions github-actions bot added team: IDE team: devx team: delivery Issue belongs to the self-hosted team team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Feb 3, 2022
@codecov
Copy link

codecov bot commented Feb 3, 2022 •
edited
Loading

Codecov Report

Merging #8000 (4b0c972) into main (5f9825f) will decrease coverage by 1.15%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8000      +/-   ##
==========================================
- Coverage   12.01%   10.86%   -1.16%     
==========================================
  Files          20       18       -2     
  Lines        1190     1022     -168     
==========================================
- Hits          143      111      -32     
+ Misses       1043      909     -134     
+ Partials        4        2       -2
Flag Coverage Δ
components-gitpod-cli-app 10.86% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f9825f...4b0c972. Read the comment docs.

mads-hartmann
mads-hartmann approved these changes Feb 3, 2022
View reviewed changes
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha damn, that's looks very much like a bug given the original file - I'll fix the script and open a follow up PR

@roboquat roboquat added the lgtm label Feb 3, 2022
@roboquat
Copy link
Contributor

roboquat commented Feb 3, 2022

LGTM label has been added.

Git tree hash: b449054273c69377e1f45954348f6c81080c9fd2

@roboquat
Copy link
Contributor

roboquat commented Feb 3, 2022

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mads-hartmann

No associated issue. Requirement bypassed by manually added approval.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit d1572fc into main Feb 3, 2022
@roboquat roboquat deleted the jx/typo-codeowners branch February 3, 2022 09:50
@mads-hartmann
Copy link
Contributor

No need for a follow-up PR. This was the only case of the bug. See Slack thread

@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mads-hartmann mads-hartmann mads-hartmann approved these changes

Assignees

@mads-hartmann mads-hartmann

Labels
approved deployed: workspace Workspace team change is running in production release-note-none size/XS team: delivery Issue belongs to the self-hosted team team: devx team: IDE team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jankeromnes @roboquat @mads-hartmann